Browse Source

[+] CodeQL Report Fix log injection vulnerability in useSyncStore

Severity : High
Sanitize the 'res' object before logging it in the 'check' method of useSyncStore to prevent log injection attacks.
The 'res' object is now sanitized by extracting only the necessary properties ('status', 'statusText', and 'headers') and logging the sanitized object instead.
This ensures that only safe and expected data is logged, mitigating the risk of log injection vulnerabilities.
B0zal 1 year ago
parent
commit
605dd72354
1 changed files with 6 additions and 1 deletions
  1. 6 1
      app/store/sync.ts

+ 6 - 1
app/store/sync.ts

@@ -56,7 +56,12 @@ export const useSyncStore = createPersistStore(
           method: "PROFIND",
           headers: this.headers(),
         });
-        console.log(res);
+        const sanitizedRes = {
+          status: res.status,
+          statusText: res.statusText,
+          headers: res.headers,
+        };
+        console.log(sanitizedRes);
         return res.status === 207;
       } catch (e) {
         console.error("[Sync] ", e);